-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Fix typo and missing article before noun in docs #13611
Conversation
@yeonjuan When I click on the license agreement it says You have signed the CLA for eslint/eslint and all of the fields are disabled. Attached an image below. |
@yeonjuan yes those are the steps that I followed to sign the CLA. I haven't used github in a while since my company uses gitlab but in gitlab you can rerun a ci/cd step in the plan. Maybe rerunning the licence/cla step again would resolve it, if the ci/cd pipeline is similar to gitlab. Could be completely wrong about that but that is how gitlab works. |
@yeonjuan Reread the link you sent and realized that my git email was set to my work email and not my personal email so that is why the commit author was not recognized. In order to link this pr with the correct email I added another minor documentation fix to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks for contributing! |
…lons.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Fixed a typo in the
developer-guide/working-with-rules#providing-suggestions
documentation - changed semicolumns to semicolons.Is there anything you'd like reviewers to focus on?